[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I don't think lldb's error messaging is great when attac

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

JDevlieghere added a comment. Nit: can we use a colon instead of dash? We have a bunch of places already where we're "concatenating" errors with a colon so I'd like to keep that consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120594/new/

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda added a comment. In D120594#3346722 , @JDevlieghere wrote: > Nit: can we use a colon instead of dash? We have a bunch of places already > where we're "concatenating" errors with a colon so I'd like to keep that > consistent. Using a dash

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda added a comment. In D120594#3346730 , @jasonmolenda wrote: > In D120594#3346722 , @JDevlieghere > wrote: > >> Nit: can we use a colon instead of dash? We have a bunch of places already >> where we'

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda updated this revision to Diff 412288. jasonmolenda added a comment. Herald added a project: All. Integrate Jonas' suggestion, update the disassemble shell test to match the new error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120594/new/ https://reviews.llvm.org/D120594 ___

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaba82362228: Refine error msgs from CommandObject & Disassemble (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120594/new/ https