[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

This revision was automatically updated to reflect the committed changes. Closed by commit rG71e278805a72: [lldb] Fix DataExtractor symbol conflict (authored by emrekultursay, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D120718?vs=412621&id=412740#toc Reposito

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits ma

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay updated this revision to Diff 412621. emrekultursay added a comment. Reverted the changes to the header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 Files: lldb/source/Core/DataFi

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

JDevlieghere added a comment. Thanks for cleaning up the implementation file. LGMT module removing the added `lldb_private::` which I believe we no longer need. Comment at: lldb/include/lldb/Core/DataFileCache.h:164 /// True if the signature was successfully decoded, fals