[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd89f94aa904: [lldb] Fix python errors in gdbremote.py (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D120792?vs=412327=412594#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. other than the comment about the json, looks all good to me! Comment at: lldb/examples/python/gdbremote.py:1224-1225 +print(json.dumps(json_tree, indent=4,

[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

ddcc added inline comments. Comment at: lldb/examples/python/gdbremote.py:1224-1225 +print(json.dumps(json_tree, indent=4, separators=(',', ': '))) +except json.JSONDecodeError: +return kastiglione wrote: > I don't know this tool, but

[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

kastiglione added inline comments. Comment at: lldb/examples/python/gdbremote.py:1224-1225 +print(json.dumps(json_tree, indent=4, separators=(',', ': '))) +except json.JSONDecodeError: +return I don't know this tool, but should it print the

[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

ddcc created this revision. ddcc added reviewers: kastiglione, jingham, JDevlieghere, clayborg. Herald added a project: All. ddcc requested review of this revision. Herald added a project: LLDB. Fix exceptions encountered while debugging gdb protocol Repository: rG LLVM Github Monorepo