This revision was automatically updated to reflect the committed changes.
Closed by commit rL245545: [NativeProcessLinux] Fix a bug in
instruction-stepping over thread creation (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12104?vs=32571&id=32669#toc
Repository:
rL
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3051
@@ +3050,3 @@
+return step_result;
+}
+default:
Let's go ahead wit
labath updated this revision to Diff 32571.
labath marked an inline comment as done.
labath added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
Address review comments
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Pl
tberghammer added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1049-1051
@@ -1047,5 +1048,5 @@
-NativeThreadProtocolSP new_thread_sp = GetThreadByID(tid);
+NativeThreadLinuxSP new_thread_sp =
std::static_pointer_cast(GetThreadByID(tid
labath updated this revision to Diff 32545.
labath added a comment.
Fix test on android arm - skip single-stepping over some functions
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
source/Plugins
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457
@@ -1453,3 +1456,3 @@
-thread_sp = AddThread(pid);
+thread_sp =
std::static_pointer_cast(AddThread(pid));
assert (thread_sp.get() && "failed to create the
labath updated this revision to Diff 32526.
labath marked 4 inline comments as done.
labath added a comment.
- Address review comments
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
source/Plugins
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457
@@ -1453,3 +1456,3 @@
-thread_sp = AddThread(pid);
+thread_sp =
std::static_pointer_cast(AddThread(pid));
assert (thread_sp.get() &&
labath created this revision.
labath added reviewers: ovyalov, tberghammer.
labath added a subscriber: lldb-commits.
There was a bug in NativeProcessLinux, where doing an instruction-level
single-step over the
thread-creation syscall resulted in loss of control over the inferior. This
happened b
