[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc38b2b7bf9: [lldb] Report debugger diagnostics as events (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: http

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/unittests/Core/DiagnosticEventTest.cpp:53-54 +TEST_F(DiagnosticEventTest, Warning) { + ArchSpec arch("x86_64-apple-macosx-"); + Platform::SetHostPlatf

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415699. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415697. JDevlieghere added a comment. Migrate a few more call sites to `Debugger::Report{Error,Warning}` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h ll

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415695. JDevlieghere added a comment. Print diagnostics directly to the debugger's error stream if nobody is listening for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415643. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Herald added a subscriber: mgorny. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Fil

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

labath added a comment. Heh, I didn't realize that "debugger-less" events are implemented by iterating over all debugger instances, but since we're doing that for progress events anyway, we might as well copy the pattern. Any chance of a test case for some of this stuff? Maybe a unittest which

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415283. JDevlieghere added a comment. Address code review: - Decentralize tracking whether a warning/error has been emitted. - Support diagnostics that are not tied to a single debugger. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

labath added a comment. It seems to me that it would be better to decentralize the warning tracking. Also due to a central list of all possible warnings not being modular, but mainly because I can imagine that some warnings may want to be reported with different "scopes" -- once per target, thr

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 414899. JDevlieghere added a comment. Use the asynchronous error stream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEven

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 414801. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Report warnings and errors through events instead of printing directly the to the debugger's error stream. Diagnostic events ar