tberghammer added a comment.
Thanks for the info about the plans. If you plan to move to this direction then
it make sense to leave these functions with reference arguments.
Side note: Why we use a shared_ptr for NTL? I would expect a unique_ptr would
be sufficient in NPL (or possibly a store b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245681: [NativeProcessLinux] Reduce the number of casts
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12187?vs=32673&id=32805#toc
Repository:
rL LLVM
http://reviews.llvm.or
labath marked an inline comment as done.
labath added a comment.
Passing around pointers (shared or otherwise) encourages people to litter the
code with null pointer checks. For the next cleanup, I would like to move these
checks to a single place and then convert more of these functions to take
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2834
@@ -2843,3 +2833,3 @@
-NativeThreadProtocolSP thread_sp (new NativeThreadLinux (this, thread_id));
+NativeThreadLinuxSP thread_sp (new Nat
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good.
One inconsistency what might worth a change is that you usually pass NPL as a
shared_ptr (or a reference to a shared_ptr) but you created a few function
where it isn't t
labath created this revision.
labath added reviewers: ovyalov, tberghammer.
labath added a subscriber: lldb-commits.
NPL used to be peppered with casts of the NativeThreadProtocol objects into
NativeThreadLinux. I
move these closer to the source where we obtain these objects. This way, the
rest
