I do. We still use this but always in a remote debugging scenario so I
never had issues with this diff and I haven't gotten around to looking at
windows unit tests at all.
On Mon, Oct 2, 2017 at 9:43 AM Zachary Turner via Phabricator <
revi...@reviews.llvm.org> wrote:
> zturner added a comment.
>
zturner added a comment.
Hi Stephane, what's the status of this? Do you still need this functionality?
Repository:
rL LLVM
https://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
sas added a comment.
Not a problem at all. Sorry for breaking the tests.
I'm setting up a Windows VM now to be able to run these tests. I'll let you
know if I'm stuck.
Repository:
rL LLVM
http://reviews.llvm.org/D12245
___
lldb-commits mailing
By the way, I'm actively working on getting the test suite completely
running on a buildbot, but I need to get down to a green baseline first.
Still a few weeks out, but hopefully this type of thing will be caught
automatically in the future.
On Fri, Aug 21, 2015 at 5:00 PM Zachary Turner wrote:
Hi Stephane, I'm sorry but I had to revert this change. When I tested it
locally, I did it without running the full test suite, but when I did run
the full test suite it showed about 15-20 new test failures. I should have
caught this earlier by running the full test suite, so sorry about that.
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245725: Implement basic DidAttach and DidLaunch for
DynamicLoaderWindowsDYLD. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12245?vs=32842&id=32853#toc
Repository:
rL LLVM
htt
sas added a comment.
Thanks for the testing. I'll definitely setup a windows box.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Tested on Windows, I don't see any problems, so lgtm.
If you're going to be doing a non-trivial amount of work on ProcessWindows
or DynamicLoaderWindows, would it be possible for you to set up a Windows
box you can test from? I'm happy to help you get this set up if you need.
On Fri, Aug 21, 201
sas added a comment.
@zturner, will do before submitting.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas updated this revision to Diff 32842.
sas added a comment.
Style.
http://reviews.llvm.org/D12245
Files:
source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
Index: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
zturner added a comment.
Can you verify that this does not break local debugging on Windows?
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Fine for now.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader plugin which allow us to load shared libraries from the
inferior.
At the moment, I'm unsure how we're going t
13 matches
Mail list logo
