[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Valgrind makes everything run much slower, so don'

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. > BTW, does it make sense to get even things like this reviewed, or is it ok if > I push these directly if I'm reasonably certain I know what I'm doing? I feel > like I'm spamming you by now. Generally, I would say yes. I'm not even sure that some of your other patches

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. Is this really something we want to hardcode at all? It seems like this should be a setting that is configured by the test harness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123020/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. If it's just a matter of setting the default timeout value, then I don't think it would be that bad -- we already set a different timeout for debug and release builds, so it we could conceivably put this there. But yes, my "setting the initial timeout value to a reasonab

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3426252 , @labath wrote: >> BTW, does it make sense to get even things like this reviewed, or is it ok >> if I push these directly if I'm reasonably certain I know what I'm doing? I >> feel like I'm spamming you by now

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3426839 , @llunak wrote: > In D123020#3426252 , @labath wrote: > >>> BTW, does it make sense to get even things like this reviewed, or is it ok >>> if I push these directl

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

clayborg added a comment. In D123020#3426867 , @JDevlieghere wrote: > In D123020#3426839 , @llunak wrote: > >> In D123020#3426252 , @labath wrote: >> BTW, does it ma

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak abandoned this revision. llunak added a comment. In D123020#3426867 , @JDevlieghere wrote: > FWIW the official policy is outlined here: > https://llvm.org/docs/CodeReview.html I'm aware of it, but as far as I can judge I was following it. Even r

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437246 , @llunak wrote: > In D123020#3426867 , @JDevlieghere > wrote: > >> FWIW the official policy is outlined here: >> https://llvm.org/docs/CodeReview.html > > I'm aw

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

clayborg added a comment. So the setting should take care of everything and we should be able to increase it when running with valgrind right? I would rather not have code all over LLDB making valgrind tests and doing something in response if possible Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437512 , @clayborg wrote: > So the setting should take care of everything and we should be able to > increase it when running with valgrind right? I would rather not have code > all over LLDB making valgrind tes

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. In D123020#3437246 , @llunak wrote: > In D123020#3426867 , @JDevlieghere > wrote: > >> FWIW the official policy is outlined here: >> https://llvm.org/docs/CodeReview.html > > I'm aware of

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3442434 , @labath wrote: > In D123020#3437246 , @llunak wrote: > >> In D123020#3426867 , @JDevlieghere >> wrote: >> >>> FWIW the offici

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. In D123020#3442738 , @llunak wrote: > Based on that 'introduce' comment I expect the part that you're not aware of > is that all 4 of those simple commits I pushed directly changed code that had > been written by me. So I still t