[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

This revision was automatically updated to reflect the committed changes. Closed by commit rG20048f3150cf: [lldb] use one shared ThreadPool and task groups (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak updated this revision to Diff 426269. llunak added a comment. Changed to use std::call_once(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/ https://reviews.llvm.org/D123226 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak marked 2 inline comments as done. llunak added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote:

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg added inline comments. Comment at: lldb/source/Core/Debugger.cpp:761 m_instance_name.SetString(llvm::formatv("debugger_{0}", GetID()).str()); + g_threadpool = std::make_unique(llvm::optimal_concurrency()); if (log_callback) clayborg wrote: >

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/Debugger.cpp:761 m_instance_name.SetString(llvm::formatv("debugger_{0}", GetID()).str()); + g_threadpool =

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak updated this revision to Diff 423246. llunak edited the summary of this revision. llunak added a comment. ThreadPool object is now created/destroyed by Debugger class ctor/dtor. Adapted to API changes from D123225 . CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak marked an inline comment as done. llunak added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote:

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; aganea wrote: > clayborg wrote: > > aganea wrote: > > >

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote: > aganea wrote: > > Ideally this should

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); +

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; Ideally this should be explicitly created on the stack &

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

tschuett added a comment. You cannot access/find the global thread pool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/ https://reviews.llvm.org/D123226 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. As a preparation for