[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

This revision was automatically updated to reflect the committed changes. Closed by commit rG68e73eaee632: [lldb] Handle empty search string in "memory find" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ http

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ https://reviews.llvm.org/D123793 ___

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

DavidSpickett added a comment. Previously this would crash. Unless we'd rather treat it as `\x0` but that could be confusing. You can always search for literal 0 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ https://reviews.l

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Given that you'd never find empty string, just error. Also add a test that an invalid expr generates an error.