[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

This revision was automatically updated to reflect the committed changes. Closed by commit rG059f39d2f445: [trace][intel pt] Support events (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. Thanks for making those changes - lgtm! Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:258 /// first one. Otherwise, this map will be empty. std::map

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace updated this revision to Diff 424658. wallace marked 3 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/ https://reviews.llvm.org/D123982 Files:

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace marked 13 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:265 +class TraceEventsUtils { +public: jj10306 wrote: > nit: maybe this will change in the future to where this will have data and >

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:265 +class TraceEventsUtils { +public: nit: maybe this will change in the future to where this will have data and instance members, but if not, consider just using a namespace

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace updated this revision to Diff 423654. wallace added a comment. address comments. Still pending response about the iff word. I've just created a stats objects for events with some util functions that make the code much cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:1151 +// Events that might happen during a trace session. +FLAGS_ENUM(TraceEvents){ +// Tracing was paused. If instructions were executed after pausing jj10306 wrote: > What are

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

jj10306 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:1151 +// Events that might happen during a trace session. +FLAGS_ENUM(TraceEvents){ +// Tracing was paused. If instructions were executed after pausing What are some other

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace updated this revision to Diff 423535. wallace added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/ https://reviews.llvm.org/D123982 Files: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A trace might contain events traced during the target's execution. For example, a