[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath updated this revision to Diff 425727. labath added a comment. Here's the updated version. I'll place my new findings into the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath planned changes to this revision. labath added a comment. In D124370#3472394 , @clayborg wrote: > So I believe the reason we need to be able to add methods to a class is for > templates. Templates in DWARF are really poorly emitted all in the

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

dblaikie added a comment. I take it no tests fail upon removing this condition? Any hints in version history about its purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

clayborg added a comment. So I believe the reason we need to be able to add methods to a class is for templates. Templates in DWARF are really poorly emitted all in the name of saving space. There is no full definition of template classes that get emitted, just a class definition with _only_

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

shafik added a comment. This mostly makes sense, the purpose of the `|| alternate_defn` was not clear to me either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath created this revision. labath added reviewers: shafik, clayborg. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The issue is somewhat hard to describe (I recommend reading the bug), but what roughly happens is that we have a type with