[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

2022-04-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9aa6a479738c: [lldb] Fix crash when launching in terminal (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D124535?vs=425542=425910#toc

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

2022-04-28 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. One could add a unit test for the CFD overload, though, as this appears to be the only callsite (or other callsites were equally untested and broken), we could also remove it altogether.

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

2022-04-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: mgorny, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch fixes a crash when using `process launch -t` to launch the inferior from a TTY. The issue is that on Darwin, Host.mm is