This revision was automatically updated to reflect the committed changes.
jingham marked 4 inline comments as done.
Closed by commit rG3339000e0bda: We dont require users to type out the
full context of a function, for (authored by jingham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/include/lldb/Target/Language.h:225
+ // symbol was really B::A::my_function. We want that to be
+ // a match. But we wouldn't want this to match
jingham marked 6 inline comments as done.
jingham added inline comments.
Comment at: lldb/include/lldb/Target/Language.h:225
+ // symbol was really B::A::my_function. We want that to be
+ // a match. But we wouldn't want this to match AnotherB::A::my_function.
The
+ //
jingham updated this revision to Diff 426170.
jingham added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124579/new/
https://reviews.llvm.org/D124579
Files:
lldb/include/lldb/Target/Language.h
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/Target/Language.h:225
+ // symbol was really B::A::my_function. We want that to be
+ // a match. But we wouldn't want
labath added a comment.
Yeah, this was very surprising.
The fact that we're still doing substring matches on the context is suspicious,
and might cause false positives, but given that we first verify that the
context is valid, I was not able to come up with counterexamples.
shafik added a comment.
You might want to try fun cases like `operator<` and `operator()()` from a
lambda. They should work but might be worth throwing them in.
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:330
+
+// size_t from = 0;
+//
jingham created this revision.
jingham added reviewers: JDevlieghere, labath, clayborg, shafik.
Herald added a subscriber: mgorny.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
We don't require users
