This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7b73de9ec2b1: [trace][intelpt] Support system-wide tracing
[3] - Refactor IntelPTThreadTrace (authored by Walter Erquinigo
wall...@fb.com).
wallace added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.h:41-48
+ /// \param[in] tid
+ /// The tid of the thread to be traced.
+ ///
+ /// \return
+ /// A \a IntelPTSingleBufferTrace instance if tracing was successful, or
jj10306 accepted this revision.
jj10306 added a comment.
This revision is now accepted and ready to land.
I'm assuming the changes to make the single buffer trace class generic for
threads and cpu buffers is done in the next diff so stamping this, feel free to
update with those changes if that
wallace updated this revision to Diff 426546.
wallace added a comment.
update test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124648/new/
https://reviews.llvm.org/D124648
Files:
lldb/docs/lldb-gdb-remote.txt
wallace added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:136
-
/// Manages a list of thread traces.
class IntelPTThreadTraceCollection {
wallace wrote:
> jj10306 wrote:
> > update doc since this is no longer tied to
wallace added inline comments.
Comment at: lldb/docs/lldb-gdb-remote.txt:498
// Binary data kinds:
-//- threadTraceBuffer: trace buffer for a thread.
+//- traceBuffer: trace buffer for a thread.
//- procFsCpuInfo: contents of the /proc/cpuinfo file.
jj10306 requested changes to this revision.
jj10306 added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/docs/lldb-gdb-remote.txt:498
// Binary data kinds:
-//- threadTraceBuffer: trace buffer for a thread.
+//- traceBuffer: trace
wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a subscriber: mgorny.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
I'm refactoring IntelPTThreadTrace into
