[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

labath added a comment. Sure, that's great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGf416e57339bd: [lldb] Fix ppc64 detection in lldb (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D124760?vs=427119=427225#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille reopened this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @labath does that version look good? I only changed the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille updated this revision to Diff 427119. serge-sans-paille added a comment. Change the rest case to something that doesn't require me to implement ppc64be corefile support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille added a comment. In D124760#3488289 , @DavidSpickett wrote: > I reverted this due to an assert: > https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio > (set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`) > > I

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

DavidSpickett added a comment. I reverted this due to an assert: https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio (set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`) I think you could just add PowerPC to the `if (!reg_interface` there but first time looking at the code I'm

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGf114f0094868: [lldb] Fix ppc64 detection in lldb (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille updated this revision to Diff 426620. serge-sans-paille added a comment. Fix nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

MaskRay accepted this revision. MaskRay added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:315 + uint32_t endian = header.e_ident[EI_DATA]; + if(endian == ELFDATA2LSB) +return ArchSpec::eCore_ppc64le_generic;

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. There were probably easier ways to test this, but it's nice to have the core file nonetheless. LGTM, assuming the core is of a reasonable size.

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, jasonmolenda, labath. Herald added subscribers: StephenFan, shchenz, kbarton, nemanjai, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: LLDB.