[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace created this revision. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diffs implements per-core tracing on lldb-server. It also includes tests that ensur

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 426737. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/TraceGDBRemot

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 426742. wallace added a comment. add one test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/Trace

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 426745. wallace edited the summary of this revision. wallace added a comment. improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:47 +self.skipTest("Per core tracing is not supported. You need " +"/proc/sys/kernel/perf_event_paranoid to be 0 or -1.") + ---

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 427449. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/TraceGDBRemot

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:372-374 +// This limit applies to the sum of the sizes of all trace and core +// buffers for the current process, excluding the ones started with +// "thread tracing". ---

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:372-374 +// This limit applies to the sum of the sizes of all trace and core +// buffers for the current process, excluding the ones started with +// "thread tracing". ---

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:228-234 + return m_per_thread_process_trace_up->TraceStart(tid); } Error IntelPTCollector::OnThreadDestroyed(lldb::tid_t tid) { - if (IsProcessTracingEnabled() && m_process_tra

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428496. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/T

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428511. wallace added a comment. Now the tracedThreads field returned by the GetState request must have the list of all the threads of the process if per-core mode is enabled. This will avoid having to make that field optional. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:248 // "name": , -// Tracing technology name, e.g. intel-pt, arm-coresight. +// Tracing technology name, e.g. intel-pt, arm-etm. // "descri

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. couple minor things, but looks good overall Comment at: lldb/docs/lldb-gdb-remote.txt:465-474 // "tid": , // "binaryData": [ //{ // "kind": ,

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:152-156 + IntelPTPerThreadProcessTraceUP m_per_thread_process_trace_up; + /// Cores traced due to per-core "process tracing". Only one active + /// "process tracing" instance is all

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:465-474 // "tid": , // "binaryData": [ //{ // "kind": , // Identifier for some binary data related to this thread to // fetch with the jLLDBTraceGet

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428687. wallace added a comment. address comments In a newer diff I'll create a base class for all "process tracing" strategies, so that we don't need to use two unique pointers for both process tracing classes in the collector. I'm not doing it here becaue

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f49714d3e19: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on… (authored by Walter Erquinigo ). Repo