clayborg added a comment.
So:
target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode);
Would get used in the stack backtracing code that is currently looking up the
real address class of the return address...
http://reviews.llvm.org/D12556
_
clayborg added a comment.
I would leave everything as is (no eAddressClassDataIntermixedCode), but I
would change the code to use:
target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode);
We don't need to lookup the address class type when determining return
addresses. Then this s
tberghammer added a comment.
In http://reviews.llvm.org/D12556#238457, @clayborg wrote:
> Changing all $d symbols to always say they are
> eAddressClassDataIntermixedCode is wrong because the symbols in the .data
> section now would be marked as eAddressClassDataIntermixedCode.
We only use th
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Marking as needing changes due to above comments.
http://reviews.llvm.org/D12556
___
lldb-commits mailing list
lldb-commits@lists.l
clayborg added a comment.
Changing all $d symbols to always say they are eAddressClassDataIntermixedCode
is wrong because the symbols in the .data section now would be marked as
eAddressClassDataIntermixedCode.
To clarify a few things, lets say we have the following code:
0x1000: bx Non-tail
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
Introduce new address class eAddressClassDataIntermixedCode
It is used for marking data what is intermixed into the code section
on arm/aar
