This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe1b88c8a09be: [clang] Only use major version in resource dir
(authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tstellar added a comment.
@tbaeder That CI failure seems unrelated. Maybe just commit early in the day
so you have time to deal with the bot failures (if any).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
tbaeder added a comment.
I'm worried that this is gonna break build bots. Has anyone seen the
ThreadSanitizer timeout reported by the precommit-ci before?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
tbaeder updated this revision to Diff 473951.
tbaeder added a comment.
Add a release note
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
Files:
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Version.inc.in
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM. Considering
https://discourse.llvm.org/t/should-we-continue-embed-the-full-llvm-version-in-lib-clang/62094
and this thread, I think overall people favor this patch.
If a
tbaeder updated this revision to Diff 473208.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
Files:
clang/include/clang/Basic/Version.inc.in
clang/lib/Driver/Driver.cpp
clang/lib/Headers/CMakeLists.txt
clang/lib/Tooling/CMakeLists.txt
sylvestre.ledru added a comment.
i hope not too many people rely on it.
LGTM but please add it to the release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
___
lldb-commits mailing list
serge-sans-paille added a comment.
The consensus in the discourse thread you mention is not super strong, but I
tend to agree with that patch. +1 for me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay.
mgorny added a comment.
Herald added subscribers: Michael137, StephenFan.
To be honest, I've never seen much purpose in the x.y.z directory naming and I
feel like it's making packaging unnecessarily more complex, at
tbaeder updated this revision to Diff 435876.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
Files:
clang/include/clang/Basic/Version.inc.in
clang/lib/Driver/Driver.cpp
clang/lib/Headers/CMakeLists.txt
clang/lib/Tooling/CMakeLists.txt
tbaeder updated this revision to Diff 435850.
Herald added a subscriber: Enna1.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
Files:
clang/include/clang/Basic/Version.inc.in
clang/lib/Driver/Driver.cpp
clang/lib/Headers/CMakeLists.txt
tbaeder created this revision.
tbaeder added a reviewer: tstellar.
Herald added a subscriber: mgorny.
Herald added a reviewer: bollu.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added subscribers: llvm-commits, openmp-commits, lldb-commits,
Sanitizers,
12 matches
Mail list logo
