[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

wallace requested review of this revision. wallace added a comment. Herald added a subscriber: Michael137. This was improved in https://reviews.llvm.org/D127752 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126015/new/

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:520 + /// core id -> data kind -> size + llvm::DenseMap> + m_live_core_data; jj10306 wrote: > Would this work instead? I noticed that the several other maps around this > code

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

jj10306 added a comment. feeback-v3 - completed review Comment at: lldb/docs/use/intel_pt.rst:168 :: { +"type": "intel-pt", Consider adding a section on the perfTscConversion parameters while we're editing this file as I don't currently see that in

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

jj10306 added a comment. feedback-v2 Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:183 +Expected> +PerfEvent::ReadFlushedOutDataCyclicBuffer(size_t offset, size_t size) { + CollectionState previous_state = m_collection_state; Do we need the

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. feedback-v1 Comment at: lldb/include/lldb/Target/Trace.h:520 + /// core id -> data kind -> size + llvm::DenseMap> + m_live_core_data;