Re: [Lldb-commits] [PATCH] D12634: Fix -data-evaluate-expression for array.

2015-09-07 Thread Hafiz Abid Qadeer via lldb-commits
abidh updated this revision to Diff 34136. abidh added a comment. Handle review comments. Moved the test to data directory and put it in a separate function. http://reviews.llvm.org/D12634 Files: test/tools/lldb-mi/data/TestMiData.py test/tools/lldb-mi/data/main.cpp

[Lldb-commits] [PATCH] D12634: Fix -data-evaluate-expression for array.

2015-09-04 Thread Hafiz Abid Qadeer via lldb-commits
abidh created this revision. abidh added a reviewer: ki.stfu. abidh added a subscriber: lldb-commits. For an array declared like "blk[2][3]", this command was showing: -data-evaluate-expression blk ^done,value="{[0] = [3], [1] = [3]}" After this fix, it shows: -data-evaluate-expression blk

Re: [Lldb-commits] [PATCH] D12634: Fix -data-evaluate-expression for array.

2015-09-04 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Source code looks good but please move the test to TestMiData.py. Comment at: test/tools/lldb-mi/variable/TestMiVar.py:39-42 @@ -38,2 +38,6 @@