[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

cmtice added a comment. Ignore my revert request; Your later commit seems to have fixed most of my issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 ___

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

cmtice added a comment. This appears to have broken a lot of LLDB tests in our bootstrap as well. Is there any chance this might get reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

mstorsjo added subscribers: stella.stamenova, mstorsjo. mstorsjo added a comment. I think this might have broken a bunch of testcases on the lldb-x64-windows-ninja buildbot too, e.g. https://lab.llvm.org/buildbot/#/builders/83/builds/20304 (CC @stella.stamenova) Repository: rG LLVM Github

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

wallace added a comment. This just broke trunk. Look at this repro: #include #include void f3() { int m; m = 2; // thread 3 - line 6 } void f2() { int n; n = 1; // thread 2 - line 11 std::thread t3(f3); t3.join(); } int main() { // main

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4298b1b8d137: Add a -b option to process continue to run to a set of breakpoints, (authored by jingham). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 438879. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 Files: lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks Jim Comment at: lldb/source/Commands/CommandObjectProcess.cpp:600 + m_options.m_run_to_bkpt_args, target, result, _to_bkpt_ids, +

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham added a comment. Herald added a subscriber: Michael137. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 435248. jingham added a comment. Fixed the option definition to specify this is a bkpt_id_list not a breakpoint id (since that's what it is now that we're using the breakpoint id list parser), and removed the verbiage that that made redundant. Added one

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham added a comment. I have to fix the doc string for the -b option since it's now a bkpt_id_list. But that won't affect the logic so I'll do that and update the patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham marked an inline comment as done. jingham added a comment. Added the ability to specify breakpoint locations to run to as well as breakpoints and breakpoint names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham marked an inline comment as done. jingham added a comment. In D126513#3550588 , @kastiglione wrote: > I noticed that the example python command and this feature don't support > specifying breakpoint locations. Should it? Man, that was WAY

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 435013. jingham added a comment. Allow for specifying breakpoint locations as well as breakpoints. Also fix the sync setting & resetting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:668 + [this, old_sync]() { +this->GetDebugger().SetAsyncExecution(!old_sync); + }); this should be `old_sync` (no `!`) Repository: rG

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added a comment. I noticed that the example python command and this feature don't support specifying breakpoint locations. Should it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Sometimes you have a complex set of breakpoints, some enabled and some