Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-09 Thread Abhishek via lldb-commits
abhishek.aggarwal added a comment. In http://reviews.llvm.org/D12677#242006, @ovyalov wrote: > I reverted the CL because it was causing > TestRegisters.test_fp_special_purpose_register_read to fail on OSX: > > - stop reason = EXC_BREAKPOINT > - "register read ftag" yields 0x80 instead of

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-08 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a subscriber: ovyalov. ovyalov added a comment. I reverted the CL because it was causing TestRegisters.test_fp_special_purpose_register_read to fail on OSX: - stop reason = EXC_BREAKPOINT - "register read ftag" yields 0x80 instead of expected 0x8000

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-07 Thread Pavel Labath via lldb-commits
labath added a subscriber: lldb-commits. Comment at: test/functionalities/register/TestRegisters.py:195 @@ +194,3 @@ +for x in range(0,16): +self.runCmd ("si", RUN_SUCCEEDED) + First I would like to applaud for writing a test case for

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-07 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. please also close the relevant bug after submission. http://reviews.llvm.org/D12677 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-07 Thread Abhishek via lldb-commits
abhishek.aggarwal added inline comments. Comment at: test/functionalities/register/TestRegisters.py:195 @@ +194,3 @@ +for x in range(0,16): +self.runCmd ("si", RUN_SUCCEEDED) + labath wrote: > First I would like to applaud for writing

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

2015-09-07 Thread Abhishek via lldb-commits
abhishek.aggarwal updated this revision to Diff 34161. abhishek.aggarwal added a comment. Clang/GCC generate different assembly for same inferior. Changed a.cpp to remove dependency of TestRegisters.py on assembly instructions generated by Clang/GCC. Changed TestRegisters.py to write a generic