ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Core/Debugger.cpp
Users:
ovyalov (Author)
http://reviews.llvm.org/rL247023
http://reviews.llvm.org/D12683
___
lldb-commits mailing list
tfiala added inline comments.
Comment at: source/Core/Debugger.cpp:426
@@ +425,3 @@
+for (const auto& debugger: debuggers)
+debugger->Clear();
+
ovyalov wrote:
> tfiala wrote:
> > Wouldn't Clear() be considered a mutating function? So a const
What were the symptoms of this? How'd you find it?
On Mon, Sep 7, 2015 at 6:47 PM Oleksiy Vyalov via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> ovyalov created this revision.
> ovyalov added a reviewer: clayborg.
> ovyalov added a subscriber: lldb-commits.
>
> Python locks in memory a
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Python locks in memory a few global objects like lldb.debugger,lldb.target,...
- as a consequence, ~Debugger isn't called upon shutdown.
Calling Debugger::Clear ensures that
ovyalov added inline comments.
Comment at: source/Core/Debugger.cpp:426
@@ +425,3 @@
+for (const auto& debugger: debuggers)
+debugger->Clear();
+
tfiala wrote:
> Wouldn't Clear() be considered a mutating function? So a const debugger ref
> seems
