Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

2015-09-09 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247133: Change the looping stack detection code (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12699?vs=34227&id=34313#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

2015-09-09 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In ABI conforming code we will never have even 2 consecutive frames with the same CFA for all ABI I know about. In practice, 2 consecutive frame with the same CFA can happen (for hand written assembly and signal handling), but more then 2 is highly unlikely. In theor

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

2015-09-08 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'm fine with this change. On x86, where the CALL instruction pushes the return address on the stack, you can't have two stack frames with the CFA. If we have a loop, I don't thi

[Lldb-commits] [PATCH] D12699: Change the looping stack detection code

2015-09-08 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Change the looping stack detection code In some special case (e.g. signal handlers, hand written assembly) it is valid to have 2 stack frame with the same CFA value. This C