[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c867898c7be: [lldb] Add setting to override PE/COFF ABI by module name (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun updated this revision to Diff 438734. alvinhochun added a comment. Added test and improved setting description as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 Files:

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file name

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun updated this revision to Diff 438133. alvinhochun added a comment. Herald added a subscriber: Michael137. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 Files:

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun updated this revision to Diff 435605. alvinhochun added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 Files: lldb/include/lldb/Interpreter/OptionValueDictionary.h

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

mstorsjo added a reviewer: omjavaid. mstorsjo added a comment. (I guess this one might need some updates after D127048 is finalized?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The setting `plugin.object-file.pe-coff.module-abi` is a string-to-enum map