[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio The second fix attempt, in

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Yep, noted. It worked for me in my MSVC build configuration -

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

stella.stamenova added a comment. This broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bae95605753: [lldb] Resolve exe location for `target create` (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun updated this revision to Diff 438737. alvinhochun added a comment. Added Windows-specific test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436 Files:

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3574289 , @alvinhochun wrote: > Does this test look good: With a bunch of minor fixups, this testcase does work - I uploaded a working copy of it at https://martin.st/temp/command-target-create-resolve-exe.test.

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun added a comment. Does this test look good: diff diff --git a/lldb/test/Shell/Commands/command-target-create-resolve-exe.test b/lldb/test/Shell/Commands/command-target-create-resolve-exe.test new file mode 100644 index ..3dfa7f0d9853 --- /dev/null +++

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun added a comment. I suppose it is possible to have a Windows-only test for this. (Someone will need to verify them for me though as I don't have a build that runs tests on Windows.) This doesn't currently work with a path without the suffix though (like

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett added a comment. Is it easy to test this? Ideally this behaviour works with a path to a file as well as `PATH` itself e.g. `C:\foo` becomes `C:\foo.exe` and you could write a test that only runs on Windows quite easily. If not I guess you could do a shell test that compiles a

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun created this revision. alvinhochun added reviewers: JDevlieghere, labath, mstorsjo. Herald added subscribers: jsji, pengfei. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an