wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This improves several things and addresses comments up to the diff [11] in this
stack.
jj10306 requested changes to this revision.
jj10306 added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: Michael137.
Looks great overall, thanks for making these improvements - just a couple minor
things
Comment at: lldb/include/lldb/Targe
wallace added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:188
+
+ bool was_enabled = m_enabled;
if (Error err = DisableWithIoctl())
jj10306 wrote:
> why this intermediate `was_enabled` variable?
it stores the original state of the
wallace requested review of this revision.
wallace added a comment.
Address in https://reviews.llvm.org/D127881
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127456/new/
https://reviews.llvm.org/D127456
wallace added inline comments.
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCoreDecoder.h:65
- TraceIntelPT &m_trace;
- std::set m_cores;
+ TraceIntelPT *m_trace;
std::set m_tids;
wallace wrote:
> jj10306 wrote:
> > why are we storing a
jj10306 accepted this revision.
jj10306 added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:188
+
+ bool was_enabled = m_enabled;
if (Error err = DisableWithIoctl())
wallace wrote:
> j
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG03cc58ff2a7a: [trace][intelpt] Support system-wide tracing
[17] - Some improvements (authored by Walter Erquinigo ).
Repository:
r
max-kudr added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
ArrayRef current_tids) {
- IntelPTP
wallace added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
ArrayRef current_tids) {
- IntelPTPr
max-kudr added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
ArrayRef current_tids) {
- IntelPTP
wallace added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
ArrayRef current_tids) {
- IntelPTPr
11 matches
Mail list logo