[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fe7e930a45: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 439433. mgorny edited the summary of this revision. mgorny added a comment. Remove the extra check from `StopSTDIOForwarding()` — we currently don't have to account for multiple processes actually running simultaneously (only the weird Linux

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +NativeProcessProtocol::Extension::multiprocess)) +assert(!m_stdio_handle_up);

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +NativeProcessProtocol::Extension::multiprocess)) +assert(!m_stdio_handle_up);

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 439405. mgorny marked an inline comment as done. mgorny added a comment. Limited variables passed into the lambda. Reworked starting stdio forwarding per the suggestion. TODO: rework stopping. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1050 + lldb::pid_t pid = process->GetID(); + m_mainloop.AddPendingCallback([&, pid](MainLoopBase ) { +m_debugged_processes.erase(pid);

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 438818. mgorny added a comment. Rebase and fix for nonstop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny planned changes to this revision. mgorny added a comment. This is now pending rebase due to the nonstop patch landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 438643. mgorny added a comment. Updated to delay removing the process (and therefore stopping lldb-server) until the last process exits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files:

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added a comment. In D127500#3595605 , @labath wrote: > I've ran into the "dynamic uninitialization order fiasco" problem as well. > I'm wondering if, instead of the trick (which is pretty neat, but still a > trick) with the limbo member

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath added a comment. I've ran into the "dynamic uninitialization order fiasco" problem as well. I'm wondering if, instead of the trick (which is pretty neat, but still a trick) with the limbo member variable, we could add something like the `asyncio.loop.call_soon` function in python to our

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 435939. mgorny added a comment. I've gotten so absorbed by fixing server code that I've forgotten to actually finish the test case ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files:

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Modify the behavior of the `k` packet to kill all inferiors rather than just the current one.