This revision was automatically updated to reflect the committed changes.
Closed by commit rL247671: Fix several issues arount dwo symbol file handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12804?vs=34550&id=34793#toc
Repository:
rL LLVM
http://reviews
tberghammer added a comment.
Thank you for the clarification. I will commit in this patch without the change
we discussed (ignoring 0 file address) and I will address that issue later.
http://reviews.llvm.org/D12804
___
lldb-commits mailing list
ll
clayborg added a comment.
I should clarify: mach-o files do have functions at zero and these are legal
DWARF and we need to read this DWARF correctly. We might be able to ask the
SymbolFile's ObjectFile about this address and if it can be a valid function
address using:
AddressClass ObjectFi
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248
@@ -2241,2 +2241,9 @@
lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd (0);
+
+// lowest_func_addr is a file address what can't be 0 because
clayborg added a comment.
I meant can't check for zero function start address in DWARFASTParserClang.cpp.
http://reviews.llvm.org/D12804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just can't check for zero in SymbolFileDWARF, other than that it looks good.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248
@@ -22
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix several issues around dwo symbol file handling
This change all dwo related test failure on Linux x86_64
http://reviews.llvm.org/D12804
Files:
source/Plugins/SymbolFile/
