labath added a comment.
How can one trigger this behavior? Adding a test would be preferable to a long
comment (we can have both, but the need for a (long) comment diminishes if you
have a test which will break if someone implements it the wrong way.
Repository:
rG LLVM Github Monorepo
CHAN
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d123783957e: [lldb][windows] Fix crash on getting nested
exception (authored by alvinhochun, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128201/new/
https://reviews.llvm.org/D128201
_
alvinhochun updated this revision to Diff 438430.
alvinhochun edited the summary of this revision.
alvinhochun added a comment.
Remove old code instead of `#if 0`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128201/new/
https://reviews.llvm.org/D
alvinhochun added a comment.
> Any reason to `#if 0` this instead of just removing it and maybe adding a one
> line comment like "nested exceptions are not supported"? So that someone can
> git blame that and find this commit with the removal.
I want to leave a clear note explaining what not to
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
Any reason to `#if 0` this instead of just removing it and maybe adding a one
line comment like "nested exceptions are not supported"? So that someone can
git blame that and find this commit with the removal.
If this
alvinhochun created this revision.
Herald added a subscriber: mstorsjo.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
LLDB tries to follow `EXCEPTION_RECORD::ExceptionRecord` to follow the
nested e
