[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

2022-06-23 Thread Chelsea Cassanova via Phabricator via lldb-commits
cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This makes the LLDB target fuzzer wr

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

2022-06-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Instead of bundling together multiple shell commands into a single one, you should break them down so CMake can have the build system (e.g. ninja) schedule the different

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

2022-06-23 Thread Chelsea Cassanova via Phabricator via lldb-commits
cassanova added a comment. This is a lot cleaner than chaining shell commands, I just implemented the second solution on my end. To clarify, it would create the directory before running the `fuzz-lldb-target` and within the `fuzz-lldb-target` we would just change the working directory to the on

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

2022-06-23 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. @cassanova You probably also want to implement this for the `command-interpreter-fuzzer` target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 __

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

2022-06-23 Thread Chelsea Cassanova via Phabricator via lldb-commits
cassanova added a comment. Yes, I can include the command interpreter's cmake file in the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 ___ lldb-commits