[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added a comment. Well... I'm as puzzled as you are. Whatever the problem is, it seems to be limited to debian (kernel). I've filed a bug about that: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014754. One good thing I learned is that this problem seems to be limited to SIGSTOPs,

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Heh, and I actually thought using `SIGSTOP` was a good idea because it's unlikely to have any unexpected side effects ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added a comment. Also, big, big thanks for helping out with this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9790406a9226: Reland "[lldb] [test] Improve stability of llgs vCont-threads tests" (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D129012?vs=442916&id=443668#toc Repository:

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Perform a major refactoring of vCont-threads tests in order to attempt to improve their stabili

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 441768. mgorny added a comment. Remove obsolete include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 Files: lldb/test/API/tools/lldb-server/vCont-threads/TestGdbRemote_vContThreads.py lldb/test/API

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 441940. mgorny added a comment. Ok, unsurprisingly it turned out that using `exit()` when the main thread was potentially suspended was a bad idea (at least it was still fairly unstable on FreeBSD). I've managed to get around that by using `_exit()` but if yo

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added a comment. Seems like an improvement. I'd like to hear what you make of the inline comment though. I can also imagine a setup where most of the verification happens inside the inferior. Like, each time a thread gets to run it increments a variable specific to that thread. Once tha

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny marked an inline comment as done. mgorny added a comment. In D129012#3631985 , @labath wrote: > I can also imagine a setup where most of the verification happens inside the > inferior. Like, each time a thread gets to run it increments a variable

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 442550. mgorny marked an inline comment as done. mgorny edited the summary of this revision. mgorny added a comment. Implement the discussed changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 Files:

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:32 + get_thread_id()); +write(STDOUT_FILENO, buf, strlen(buf)); +

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 442823. mgorny edited the summary of this revision. mgorny added a comment. Ok, so the previous version was fundamentally botched wrt synchronization. Here's a new that: 1. Uses a barrier to ensure that all threads actually start before we `SIGSTOP`. Otherwi

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath accepted this revision. labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; I guess this should technically be a `vol

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; labath wrote: > I guess this should technically be a `volatile sig_atomi

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; mgorny wrote: > labath wrote: > > I guess this should technically be a `

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; labath wrote: > mgorny wrote: >

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG86e472317c8f: [lldb] [test] Improve stability of llgs vCont-threads tests (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added a comment. Herald added a subscriber: JDevlieghere. @labath, any clue why it'd be broken on Debian? https://lab.llvm.org/buildbot/#/builders/68/builds/35396 AssertionError: '$T0athread:1ddf55;name:a.out;00:;01:;02:e1bf0b8 [truncated]... != '$W00'