[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Decouple TSCs from trace items - Turn TSCs into events just like CPUs - Add a GetWallTime that returns the wall time that

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 445664. wallace edited the summary of this revision. wallace added a comment. Herald added subscribers: jsji, pengfei. fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:183 -DecodedThread::TscRange::TscRange(std::map::const_iterator it, +DecodedThread::TscRan

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

jj10306 added a comment. AFAICT this doesn't handle the TSCs we get for CPU change events through the context switch traces, is that correct? This will be very useful to have for visualization purposes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 445980. wallace added a comment. .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceDu

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

jj10306 requested changes to this revision. jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyTsc(execution.thread_execution.GetLowestKnownTSC()); decoded_thread.NotifyCPU(execution.thread_executio

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446281. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceDum

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446303. wallace edited the summary of this revision. wallace added a comment. final version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446306. wallace added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/T

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyTsc(execution.thread_execution.GetLowestKnownTSC()); decoded_thread.NotifyCPU(execution.thread_execution.cpu_id); jj10306 wrote: >

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446541. wallace added a comment. fix a bug that happens when the initial trace items don't have timing information Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Fi

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4f676c2599eb: [trace][intel pt] Introduce wall clock time for each trace item (authored by Walter Erquinigo