This revision was automatically updated to reflect the committed changes.
Closed by commit rL248280: Do not use pthread_setname_np() if we don't have
GLIBC or Android. (authored by vkalintiris).
Changed prior to commit:
http://reviews.llvm.org/D13019?vs=35357&id=35374#toc
Repository:
rL LLVM
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
This revision is now accepted and ready to land.
looks good
http://reviews.llvm.org/D13019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
vkalintiris updated this revision to Diff 35357.
vkalintiris added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
Addressed reviewers comments.
http://reviews.llvm.org/D13019
Files:
source/Host/linux/HostThreadLinux.cpp
Index: source/Host/linux/HostThreadLinux.cpp
labath added a subscriber: labath.
Comment at: source/Host/linux/HostThreadLinux.cpp:44
@@ -38,2 +43,3 @@
{
+#if defined(__GLIBC__) && defined(_GNU_SOURCE)
// Read /proc/$TID/comm file.
While the pthread functions is a glibc extension, the presence of the co
brucem added a subscriber: brucem.
brucem added a comment.
This would break this feature on Android, no?
http://reviews.llvm.org/D13019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
vkalintiris created this revision.
vkalintiris added reviewers: clayborg, ovyalov.
vkalintiris added a subscriber: lldb-commits.
pthread_{get,set}name_np() are nonstandard GNU extensions which are
included only when _GNU_SOURCE is defined under GLIBC.
http://reviews.llvm.org/D13019
Files:
sour