[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e6b6522296e: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName() (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as all values being set on the location differ from any that might be set on the breakpoint itself for any get/set tests you added this is good to go! Repository: rG LLVM

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon marked an inline comment as done. fixathon added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448463. fixathon added a comment. Address the review comments and inline the tests into an existing test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. Looks good. I would just inline the contents of shadowed_bkpt_locations_setters_getters_test into test_shadowed_location_getters_setters since it isn't use anywhere else. Comment at:

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448457. fixathon added a comment. Fix duplicate name of the test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files:

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448453. fixathon added a comment. Added unit tests, and verified the fix is working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files:

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon planned changes to this revision. fixathon added a comment. Working on adding unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. Thanks for the info! Should be easy to test this function at least like you mentioned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660

Re: [Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

So far as I can tell, we don't have any significant tests for the "queue specific breakpoint or breakpoint location" feature. There's a pretty extensive test for identifying queues & getting more detail from them in test/API/macosx/queues/TestQueues.py, but it doesn't test the breakpoint

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. There must be a test for this, obviously we don't have one, but check the blame log and ask the original author how this should be tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, labath. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Seems like a typo in the function that never returns a significant