Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-11-09 Thread Dawn Perchik via lldb-commits
dawn added a subscriber: dawn. dawn closed this revision. dawn added a comment. This was committed in svn r251820. Repository: rL LLVM http://reviews.llvm.org/D13073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-10-29 Thread Ryan Brown via lldb-commits
ribrdb added a comment. Is this ready to submit? Comment at: source/Expression/LLVMUserExpression.cpp:43-60 @@ +42,20 @@ + +LLVMUserExpression::LLVMUserExpression(ExecutionContextScope _scope, const char *expr, const char *expr_prefix, +

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-10-29 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, that looks good. Repository: rL LLVM http://reviews.llvm.org/D13073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-10-21 Thread Zachary Turner via lldb-commits
On Tue, Oct 20, 2015 at 7:40 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > jingham added a comment. > > The generic parts of this change look fine to me, with a few inlined style > comments. > > I didn't read the Go specific parts of this in detail, I assume you're >

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-10-20 Thread Jim Ingham via lldb-commits
jingham added a comment. The generic parts of this change look fine to me, with a few inlined style comments. I didn't read the Go specific parts of this in detail, I assume you're going to get those right. I mentioned a couple of style things inline, though I didn't mark everywhere that

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-09-23 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. We need to get Sean Callanan as a reviewer on this. Jim is out for a few weeks, so Sean will need to OK this. Repository: rL LLVM http://reviews.llvm.org/D13073

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-09-23 Thread Greg Clayton via lldb-commits
clayborg added a subscriber: clayborg. clayborg added a comment. Even though clang isn't done this way for historical reason, I would like to see the Go expression parser files (.cpp and .h) over into "source/Plugins/ExpressionParser/Go". The following files should be moved:

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

2015-09-23 Thread Ryan Brown via lldb-commits
ribrdb added a comment. Hmm. I assumed you're using clang to generate llvm IR, is that not the case? I don't really want to write a whole go compiler. Right now I'm interpreting the AST using the ValueObject API. This also lets me reuse the error checking and things implemented in the type