[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath created this revision. labath added a reviewer: DavidSpickett. Herald added subscribers: JDevlieghere, kbarton, nemanjai. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Currently, lldb-server was opening the executable file to determine

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett added a comment. Tell me if I understand the strategy. If you're on arm64 but the process is actually arm32 and you ask for the general registers, you'll get back something with size < the size you expect for the 64 bit register set. If you're on arm32 then you always assume that

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath marked an inline comment as done. labath added a comment. In D130985#3693453 , @DavidSpickett wrote: > Tell me if I understand the strategy. > > If you're on arm64 but the process is actually arm32 and you ask for the > general registers, you'll

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath updated this revision to Diff 449282. labath added a comment. rename the size variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 _

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c39e2abc31: [lldb] Fix TestDeletedExecutable on linux (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

omjavaid added a comment. This broke LLDB AArch64 buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27004 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 __

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath added a comment. In D130985#3699095 , @omjavaid wrote: > This broke LLDB AArch64 buildbot: > https://lab.llvm.org/buildbot/#/builders/96/builds/27004 I see it. Looking now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http