[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

rupprecht added a comment. In D131437#3751366 , @bkramer wrote: > This seems to trigger a use after free in `lldb-api :: > functionalities/thread/create_after_attach/TestCreateAfterAttach.py` > > asan log: > > ==4741==ERROR: AddressSanitizer: heap-use-

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

bkramer added a comment. This seems to trigger a use after free in `lldb-api :: functionalities/thread/create_after_attach/TestCreateAfterAttach.py` asan log: ==4741==ERROR: AddressSanitizer: heap-use-after-free on address 0x62f00023bf58 at pc 0x563639db88f1 bp 0x7ffd942412f0 sp 0x7ffd942412

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG613336da8ce1: Don't index the skeleton CU when we have a fission compile unit. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131437/n

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D131437#3741132 , @clayborg wrote: > So I can't get -fsplit-dwarf-inlining to emit anything when I try to cross > with clang. I add the flag but no

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg updated this revision to Diff 454695. clayborg added a comment. Added a test case that tests that we can load a .dwo file with a DWO ID of zero. Was unable to get clang to emit extra stuff in the skeleton compile unit even with -fsplit-dwarf-inlining. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg added a comment. So I can't get -fsplit-dwarf-inlining to emit anything when I try to cross with clang. I add the flag but no extra function info gets emitted in the dwarf in the main executable. I tried: clang++ -gdwarf-5 -gsplit-dwarf -fsplit-dwarf-inlining -c main.cpp -o main2.o

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath added a comment. In D131437#3710203 , @clayborg wrote: > In D131437#3709921 , @labath wrote: > >> Seems reasonable, but could use a test case, though I'm not sure what would >> be the best way to approach

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg added a comment. In D131437#3709921 , @labath wrote: > Seems reasonable, but could use a test case, though I'm not sure what would > be the best way to approach that. I suppose one could dump the index of one > of these dwo-less files, and then

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath added a comment. Seems reasonable, but could use a test case, though I'm not sure what would be the best way to approach that. I suppose one could dump the index of one of these dwo-less files, and then make sure it's contents are right (empty?). The m_dwo_id change also looks like its f

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When fission is enabled, we were inde