[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG9525015c1bed: [lldb][tests] Test queue-specific breakpoints (authored by cassanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://revie

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) JDevlieghere wrote: > Any reason this should

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) Any reason this should be a separate func

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452853. cassanova added a comment. Added the queue-specific breakpoints to their own test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files: lldb/test/API/ma

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:201-206 +# Run the executable until the stopper function and get the breakpoint +# that's created from that. Then set the queue name of the breakpoint +# to be the name

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoi

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452302. cassanova added a comment. Changed an `assertTrue` to `assertEqual`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files: lldb/test/API/macosx/queues/Te

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +self.assertTrue(queu

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib accepted this revision. mib added a comment. LGTM with @teemperor feedback ! Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(),

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

teemperor added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +self.assertTrue(queu

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:204-206 +process_info = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False) +main_thread = process_info[2] +queue_breakpoint = process_info[3] -

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452275. cassanova added a comment. All variables needed from `run_to_name_breakpoint` are obtained in one line rather than getting them by index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ htt

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:204-206 +process_info = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False) +main_thread = process_info[2] +queue_breakpoint = process_info[3] ---

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452267. cassanova added a comment. Use the enum name for the stop reason when asserting that the queues hit their breakpoints instead of just the raw number. Also, get the main thread from `run_to_name_breakpoint` instead of getting it from `get_threads_s

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName())) +self.assertEqual(queue1_thread.GetStopReason(), 3, +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName())) +self.assertEqual(queue1_thread.GetStopReason(), 3, +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

DavidSpickett added a comment. Please include more context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) in future patches. Thanks for the tests regardless! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 _

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib, jingham. cassanova added a project: LLDB. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds tests to ensure that queue-specific breakpoin