ovyalov added a comment.
I tried Nexus 5 and 6P with Android M. Thanks for the new patch - it's fixing
the problem.
Repository:
rL LLVM
http://reviews.llvm.org/D13162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
I haven't managed to reproduce the issue you reported (what OS and Android
version do you use?), but based on the description this change (not
committed in yet) might fix the issue: http://reviews.llvm.org/D13293. Can
you take a look?
Thanks,
Tamas
On Wed, Sep 30, 2015 at 12:49 AM Oleksiy Vyalov
ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:341
@@ -347,1 +340,3 @@
+AdbClient adb(m_device_id);
+
StreamString command;
I tried this CL on my device and it's failing to download a symbol
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL248788: Change oat symbolization code for android to work on
non-rooted devices (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/
tberghammer marked 3 inline comments as done.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
[this](std::string* s) {
+AdbClient adb(m_device_id);
+
ovyalov wrote:
> Could you reuse adb variable defined
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Minor comments
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:231
@@ +230,3 @@
+
+size_t n = m_conn.Read(buffer, sizeof(buffer), 1000 * (timeout_ms -
ela
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as
