[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3736793 , @mgorny wrote: > @aprantl, why did you revert d38985a36be8b0165787f8893b3d2b0f831d1e83 > ? This > change had nothing to do with this pa

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny added a comment. @aprantl, why did you revert d38985a36be8b0165787f8893b3d2b0f831d1e83 ? This change had nothing to do with this patch, and you broke Windows buildbot again. If you really can't wait a few hours for me t

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f50883c1328: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 accepted this revision. Michael137 added a comment. In D131758#3735763 , @mgorny wrote: > @aprantl, @Michael137, could you confirm that this version works correctly? `ninja check-lldb-api` runs fine with your patch CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny updated this revision to Diff 454058. mgorny added a comment. @aprantl, @Michael137, could you confirm that this version works correctly? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131758/new/ https://reviews.llvm.org/D131758 Files: lldb/source/Plugins/Process/gdb-remote/GD

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3735670 , @mgorny wrote: > In D131758#3735628 , @aprantl wrote: > >> In D131758#3735621 , @Michael137 >> wrote: >> >>> This seems t

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3735670 , @mgorny wrote: > In D131758#3735628 , @aprantl wrote: > >> In D131758#3735621 , @Michael137 >> wrote: >> >>> This seems t

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny added a comment. In D131758#3735628 , @aprantl wrote: > In D131758#3735621 , @Michael137 > wrote: > >> This seems to cause all API tests to time out. >> >> See LLDB Incremental buildbot: >> https://green.

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

aprantl added a comment. In D131758#3735621 , @Michael137 wrote: > This seems to cause all API tests to time out. > > See LLDB Incremental buildbot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/ > > Can we reve

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. Herald added a subscriber: JDevlieghere. This seems to cause all API tests to time out. See LLDB Incremental buildbot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/ Can we revert this until we know what the root cause is? Re

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

This revision was automatically updated to reflect the committed changes. mgorny marked 2 inline comments as done. Closed by commit rGccb9d4d4addc: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1189-1192 + std::string pid_prefix; + if (GetID() != LLDB_INVALID_PROCESS_ID && + m_gdb_comm.GetMultiprocessSupported

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1189-1192 + std::string pid_prefix; + if (GetID() != LLDB_INVALID_PROCESS_ID && +

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny created this revision. mgorny added reviewers: labath, jingham, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Try to always send vCont packets and include the PID in them if running multiprocess. This is