[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad6ed0e5519: Change the meaning of a UUID with all zeros for data. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132191/new/ https:/

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham updated this revision to Diff 456473. jingham added a comment. Herald added subscribers: arphaman, MaskRay, emaste. Herald added a reviewer: ributzka. Remove the static factories and replace them with constructors. This was mostly mechanical, but a biggish patch against the previous versi

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

labath accepted this revision. labath added inline comments. Comment at: lldb/include/lldb/Utility/UUID.h:47 + /// Creates a UUID from the data pointed to by the bytes argument. static UUID fromData(const void *bytes, uint32_t num_bytes) { if (bytes) Th

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham added a comment. Remember, all this patch does is make a universal rule that "All zero UUID's are placeholders and not meant to be matched against." The only platforms/ObjectFile readers that weren't already following that rule were Darwin - where this was definitely just historical ac

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham added a comment. In D132191#3734014 , @clayborg wrote: > Minidump files have UUID values that are zeroed out. We will need to do > something for these that can sense all zeroes and return a default > constructed one. I'm confused. The MinidumP

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

clayborg added inline comments. Comment at: lldb/source/API/SBModuleSpec.cpp:137 LLDB_INSTRUMENT_VA(this, uuid, uuid_len) - m_opaque_up->GetUUID() = UUID::fromOptionalData(uuid, uuid_len); + m_opaque_up->GetUUID() = UUID::fromData(uuid, uuid_len); return m_opaque_up->GetU

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Minidump files have UUID values that are zeroed out. We will need to do something for these that can sense all zeroes and return a default constructed one. Co

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. At present, there are two ways to get data into a UUID object, an u