[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat added a comment. In D132734#3887018 , @JDevlieghere wrote: > Thanks Will, let me apply this locally and see if that addresses the issue > for which I reverted the original patch. Hy Jonas, sorry for bumping an old thread, but did you manage to

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw added a comment. Mr. Sabolčec, Thank you for the kind response -- I hope my work was helpful! It was lots of fun to dig in to this part of the codebase! Sincerely, Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi added a comment. Thanks for the fix Will! Just one question: cpp test file contains the expression `a[10].c` and the test complains about the expression path `a->c`. If I understand correctly, with the latest fix, that would become `a[10]->c`, which is not the original expression

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Thanks Will, let me apply this locally and see if that addresses the issue for which I reverted the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw added a comment. If you would like, I'd be happy to reopen this patch as a separate issue if that's the better way to handle it! Sorry for the SPAM! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw reopened this revision. hawkinsw added a comment. This revision is now accepted and ready to land. I updated this revision with the following change and I *think* that things are happy again: diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp index

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:1947 - // name ([%d]) to the expression path - if (m_flags.m_is_array_item_for_pointer && - epformat == eGetExpressionPathFormatHonorPointers) I am *absolutely* not an expert

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Hey, this patch still breaks TestArray.py. Could you please take another look? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/47748/testReport/lldb-api/commands_frame_diagnose_array/TestArray_py/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG0205aa4a0257: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi added a comment. Hi, I fixed the issue causing macOS tests to fail, but I don't have a macOS machine to verify it actually works. I'd be grateful if someone could check that part. I also decided to further reduce number of parenthesis in output (e.g. `(*(ptr)).member` isn't ideal),

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi updated this revision to Diff 466043. tonkosi edited the summary of this revision. tonkosi added a comment. Fixed the issue of printing unnecessary parenthesis, which broke API tests on macOS. Improved use of parenthesis to produce outputs such as `(*ptr).member` instead of

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

mib added a comment. In D132734#3827361 , @werat wrote: > In D132734#3827245 , @mib wrote: > >> Let me know if you need help reproducing and fixing these issues, otherwise >> I'll have to revert your patch. > >

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat reopened this revision. werat added a comment. This revision is now accepted and ready to land. In D132734#3827245 , @mib wrote: > Let me know if you need help reproducing and fixing these issues, otherwise > I'll have to revert your patch. Sorry

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

mib added a comment. Hi @tonkosi! I think your patch broke the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/47258/console Failed Tests (5): lldb-api :: commands/frame/diagnose/array/TestArray.py lldb-api :: commands/frame/diagnose/bad-reference/TestBadReference.py

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG14642dc7405e: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

clayborg accepted this revision. clayborg added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi updated this revision to Diff 463158. tonkosi added a comment. Forgot to propagate "epformat" when calling GetExpressionPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 Files:

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat accepted this revision. werat added reviewers: clayborg, granata.enrico. werat added a comment. This revision is now accepted and ready to land. Nice fix! It would be nice to remove redundant parenthesis, e.g. `(*(ptr)).member -> (*ptr).member`, but I see this is non-trivial with the

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi created this revision. tonkosi added reviewers: werat, Michael137. Herald added a project: All. tonkosi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change fixes two issues in ValueObject::GetExpressionPath method: 1.