[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, jasonmolenda. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While investigating slow tests, I noticed that `TestLl

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. The test that's using `iostream` could be rewritten to use `printf` instead. It actually looks like most of those test can be compiled as C programs, which should speed this up even more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. The file in question uses c++ headers: lldb/test/API/tools/lldb-server/main.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. I updated the description to remove the mention of `iostream`, since that's not the specific problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

labath added a comment. I don't think this will work in general, as the modules feature requires all your dependencies to be modularized, and linux systems generally don't have that. You might be able to do a feature like "build no_debug_info tests with modules if the platform supports it" and

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. In D132868#3758826 , @labath wrote: > I don't think this will work in general, as the modules feature requires all > your dependencies to be modularized, and linux systems generally don't have > that. You might be able to d

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. There are a number of Makefiles that use `MANDATORY_MODULE_BUILD_CFLAGS` unconditionally. Given the points made here, how do those test work on linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://r