yinghuitan updated this revision to Diff 458809.
yinghuitan added a comment.
Address review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133038/new/
https://reviews.llvm.org/D133038
Files:
lldb/bindings/interface/SBDebugger.i
lldb/i
clayborg added inline comments.
Comment at: lldb/bindings/interface/SBTarget.i:969
+lldb::SBStructuredData GetSourceMap();
+
Do we want to actually have something more like this:
```
lldb::SBStructuredData GetSetting(const char *setting);
```
That allows us
jingham added a comment.
I'm a little sad that we don't yet have a way to read the current value of a
setting into an SBStructuredData, so we do this piecemeal instead. But that's
a bigger project, so if you need this now, it doesn't seem fair to block you on
that. We should really name the o
yinghuitan updated this revision to Diff 457046.
yinghuitan added a comment.
Herald added a subscriber: JDevlieghere.
Re-diff with clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133038/new/
https://reviews.llvm.org/D133038
Files:
lld
yinghuitan created this revision.
yinghuitan added reviewers: clayborg, labath, aadsm, kusmour.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch adds a new SBTarget::GetSourceMap() API which
