[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

MaskRay added a comment. D134385 should fix the problem:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://reviews.llvm.org/D133525 ___ lldb-commits ma

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

MaskRay added inline comments. Comment at: llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp:509 + const ElfType OutputElfType = + getOutputElfType(Config.OutputArch.value_or(MachineInfo())); + const bool Is64Bit = This is incorrect. Config.OutputArch is usually unset (

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

MaskRay added a comment. See `test/tools/llvm-objcopy/ELF/compress-debug-sections-zstd.test`. Use a similar file for ELFCLASS32 which runs `llvm-objcopy --compress-debug-sections=zstd` then `llvm-objcopy --decompress-debug-sections`. Then compare the output with the original with just one `ll

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

phosek added a comment. Would it be possible to write a test that covers this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://reviews.llvm.org/D133525 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy, and add zstd support to Decompressor

ckissane updated this revision to Diff 458875. ckissane added a comment. - remove lldb changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://reviews.llvm.org/D133525 Files: llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp llvm/lib/ObjCo

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy, and add zstd support to Decompressor

ckissane updated this revision to Diff 458871. ckissane added a comment. - fix extra bytes when compressing for 32bit objcopy - fix lldb compressed section zstd test File Size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://review

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

ckissane created this revision. ckissane added a reviewer: MaskRay. Herald added subscribers: StephenFan, abrachet, hiraditya, mgorny, emaste. Herald added a reviewer: jhenderson. Herald added a project: All. ckissane requested review of this revision. Herald added projects: LLDB, LLVM. Herald adde