This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5a9e21305803: [LLDB] Fix crash when printing a struct with a
static signed char member (authored by DavidSpickett).
Repository:
rG LLVM Github
DavidSpickett added inline comments.
Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39
const static auto char_min = std::numeric_limits::min();
const static auto uchar_min = std::numeric_limits::min();
shafik wrote:
> We use
shafik accepted this revision.
shafik added a comment.
LGTM
Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39
const static auto char_min = std::numeric_limits::min();
const static auto uchar_min = std::numeric_limits::min();
DavidSpickett updated this revision to Diff 465342.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135170/new/
https://reviews.llvm.org/D135170
Files:
clang/lib/AST/StmtPrinter.cpp
DavidSpickett created this revision.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added projects: clang, LLDB.
Herald added subscribers: lldb-commits, cfe-commits.
As with static bool for whatever reason printing them on their own
worked fine but wasn't
