[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, clayborg, mib. Herald added a project: All. JDevlieghere requested review of this revision. This patch copies over log files to the diagnostic directory. It's a bit of a straw man proposal as it has some shor

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

labath added a comment. seems fine to me. Comment at: lldb/test/Shell/Diagnostics/TestCopyLogs.test:3 +# RUN: mkdir -p %t +# The "ll''db" below is not a typo but a way to prevent lit from substituting 'lldb'. +# RUN: %lldb -o 'log enable ll''db commands -f %t/commands.log' -o

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. So either way, if someone was running with no logs enabled we would have to ask them to enable them then re-run and get a new set of diagnostics (which is fine as is , not a criticism). Option 1 they would need to add `-o "log enable gdb-remote packets -f "`. Opti

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. Also is the buffer option the same as "circular" here? -h ( --log-handler ) Specify a log handler which determines where log messages are written. Values: default | stream | circular | os So we could have diagnostics also save anything kept in "ci

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D135631#3849295 , @DavidSpickett wrote: > So either way, if someone was running with no logs enabled we would have to > ask them to enable them then re-run and get a new set

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. > Technically yes, but then we have two ad-hoc solutions that support half the > log handlers. I think if we care about that we might as well go with the > T-based log handler behind the scenes. Sure. More wondering whether the choice between circular buffer and f

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere updated this revision to Diff 472812. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 Files: lldb/source/Core/Debugger.cpp lldb/test/Shell/Dia