[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd00c4db747e: Fix breakpoint setting so it always works when there is a line entry in a… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 469344. clayborg added a comment. Also test on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files: lldb/source/Symbol/CompileUnit.cpp

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 469342. clayborg added a comment. Create a new "resolved_sc" that gets used to resolve the line_entry's address. If the resolving goes to plan, append that symbol context, else append the original one. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

labath added inline comments. Comment at: lldb/source/Symbol/CompileUnit.cpp:336 } else { line_entry.range.GetBaseAddress().CalculateSymbolContext(, resolve_scope); I think this would be

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 468738. clayborg added a comment. Added missing file for real this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files: lldb/source/Symbol/CompileUnit.cpp

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg added a comment. In D136207#3866729 , @jingham wrote: > Seems reasonable that when resolving the start address of a line entry from > CU A we get back a line entry in CU B, then there's just something wrong in > the debug info. Trying to

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 468737. clayborg added a comment. Added missing test case file and clarified comments to be more consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files:

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

jingham added a comment. Seems reasonable that when resolving the start address of a line entry from CU A we get back a line entry in CU B, then there's just something wrong in the debug info. Trying to recover whatever info is recoverable seems worthwhile: essentially by falling back to a